I'm on it

LGTM 🚀

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted correction to Find-Rooms-in-a-Workspace.md to reflect the behavior change from #96603 (the Workspace Rooms page released to all members and admins). The edits correct the room-open flow so it distinguishes between Workspace admins (open the room details page, then Go to room) and Workspace members (open the conversation directly). The change is accurate, well-scoped, and improves correctness. All feedback below applies only to the modified lines.

Scores Summary

• Readability: 9/10 - The rewritten "What happens after you open a room" section is clear and scannable, using a role-based bullet list. One trailing-whitespace nit on the "displays the rooms you can access" line.
• AI Readiness: 9/10 - Task-based headings, full feature names (Rooms directory, Workspace admins/members), and complete YAML metadata including internalScope are all present and unchanged. The edits keep the single-workflow focus intact.
• Style Compliance: 9/10 - UI labels (Rooms, Go to room, Workspaces), sentence casing, and the unified navigation phrasing "(on the left on web, on the bottom on mobile)" all follow HELPSITE_NAMING_CONVENTIONS.md. Terminology (Workspace member/admin) is correct.

Key Findings

• Accurate correction: the previous text implied every user opens a details page then clicks Go to room; the new version correctly splits admin vs. member flows, matching WorkspaceRoomsPage.tsx.
• Good consistency fix: adding the missing period to step 1 aligns it with the other numbered steps.
• Minor nit: a trailing space was introduced at the end of the line "The Rooms directory displays the rooms you can access in that workspace. " - remove it.
• Note (not blocking): HELP_AUTHORING_GUIDELINES.md Section 6 says to avoid combining Admin + Member flows "unless inseparable." Here they are genuinely inseparable (same action, divergent outcome), so the role-based bullet treatment is appropriate.

Recommendations

• Remove the trailing whitespace on the "displays the rooms you can access in that workspace." line.
• Optional: consider whether the shortened step 3 ("Select a room from the list.") should briefly point readers to the "What happens after you open a room" section, since the outcome now varies by role. Not required.

Files Reviewed

• docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md - Approved with one minor whitespace nit. Correction is accurate and compliant with governance.

Note: Detailed line-by-line feedback has been provided as inline comments.

Concierge reviewer checklist:

• I have verified the accuracy of the article
  • The article is within a hub that makes sense, and the navigation is correct
  • All processes, screenshots, and examples align with current product behavior.
  • All links within the doc have been verified for correct destination and functionality.
• I have verified the readability of the article
  • The article's language is clear, concise, and free of jargon.
  • The grammar, spelling, and punctuation are correct.
  • The article contains at least one image, or that an image is not necessary
• I have verified the formatting of the article
  • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
  • The article has proper text spacing and breaks for readability.
• I have verified the article has the appropriate tone and style
  • The article's tone is professional, friendly, and suitable for the target audience.
  • The article's tone, terminology, and voice are consistent throughout.
• I have verified the overall quality of the article
  • The article is not missing any information, nor does it contain redundant information.
  • The article fully addresses user needs.
• I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

A preview of your ExpensifyHelp changes have been deployed to https://0f91f8e0.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/chat/Find-Rooms-in-a-Workspace

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos